Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IH Schedule Page 2025 #581

Merged
merged 15 commits into from
Jan 24, 2025
Merged

IH Schedule Page 2025 #581

merged 15 commits into from
Jan 24, 2025

Conversation

Bl20052005
Copy link
Contributor

@Bl20052005 Bl20052005 commented Jan 20, 2025 •
edited
Loading

Draft, IP items include

  • getting weekday switching to work (with continuous scroll)
  • getting weekday switching to work (with clicking and chevrons)
  • formatting issues regarding unlocked text
  • adding decor to the sides of event sidebar
  • adding cloud decor around the entire page
  • fixing spacing for plaques on mobile views

This was linked to issues Jan 20, 2025
Schedule Countdown #567
Closed
Rest of schedule page #568
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Deploy preview for irvinehacks-site-2025 ready!

Name IrvineHacks Site
Preview Visit Preview
Commit 6449fae

@Bl20052005 Bl20052005 marked this pull request as ready for review January 20, 2025 23:15
@Bl20052005 Bl20052005 requested a review from waalbert January 21, 2025 04:23
IanWearsHat
IanWearsHat requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good, great even! Just quite a few notes on cleaning up code.

apps/site/src/app/(main)/schedule/components/EventCard.tsx Show resolved Hide resolved
apps/site/src/app/(main)/schedule/components/EventPlaque.tsx Show resolved Hide resolved
apps/site/src/app/(main)/schedule/components/EventSidebar.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(main)/schedule/components/ShiftingCountdown/FinalAnimation.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(main)/schedule/components/ShiftingCountdown/ShiftingCountdown.tsx Show resolved Hide resolved
apps/site/src/app/(main)/schedule/components/ShiftingCountdown/ShiftingCountdown.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(main)/schedule/page.tsx Show resolved Hide resolved
apps/site/src/app/(main)/schedule/sections/SchedulePage.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(main)/schedule/sections/SchedulePage.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(main)/schedule/sections/ScheduleScroll.tsx Outdated Show resolved Hide resolved
IanWearsHat
IanWearsHat previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for taking this entire page Bo!

waalbert
waalbert previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@waalbert waalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bo for tackling this big task! A few things to fix before merging:

  • HACKING_STARTS and HACKING_ENDS need to be updated
  • Changing the days doesn't update visually

@Bl20052005 Bl20052005 dismissed stale reviews from waalbert and IanWearsHat via 0ae5bcd January 24, 2025 22:13
@Bl20052005 Bl20052005 requested a review from waalbert January 24, 2025 22:33
waalbert
waalbert approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@waalbert waalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bo!

@waalbert waalbert merged commit e8030ea into main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waalbert waalbert waalbert approved these changes

@IanWearsHat IanWearsHat IanWearsHat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rest of schedule page Schedule Countdown
3 participants
@Bl20052005 @IanWearsHat @waalbert